This repository has been archived by the owner on Apr 9, 2024. It is now read-only.
Don't connect to websocket unless CUCUMBER_PRO_TOKEN is set #2
Comments
aslakhellesoy
added a commit
that referenced
this issue
Jun 28, 2014
This makes it easier to add the formatter without having to conditionally enable it. If CUCUMBER_PRO_TOKEN is not defined, the formatter does not check if the working copy is clean, and it does not connect to the server. This is how the Cucumber-JVM implementation works now. When Cucumber-Ruby is able to read command line options from a simple file (cucumber.opts), it will be a lot easier to automate the installation of the formatter. This fixes #2.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The rationale for this is that we want to enable the formatter in a
cucumber.optsfile, which is easy for Cucumber Pro to update when we're enabling results.If the formatter is always enabled the current implementation will always fail for developers.
The formatter should do nothing unless
CUCUMBER_PRO_TOKENis defined. Normally this will only be defined in CI.The text was updated successfully, but these errors were encountered: