Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support output verbosity #140

Closed
tyranron opened this issue Oct 12, 2021 · 1 comment
Closed

Support output verbosity #140

tyranron opened this issue Oct 12, 2021 · 1 comment
Assignees
@ilslv
Labels
enhancement Improvement of existing features or bugfix
Milestone
0.10

Comments

@tyranron
Copy link
Member

Revealed from #56 (comment)

@tyranron writer::Basic now outputs only step name itself and table, if present. No docstrings.

@ilslv should we support docstrings outputting as opt-in? Maybe some kind of --verbose CLI opt?

@tyranron I would argue that docstrings are useful as diagnostics (as shown in this issue) or for more verbose explanation, which I'm not sure is useful as part of output. And most importantly, we'll need a way to show 1 set of cli options, if writer::Basic is present and the other one if some other OutputWriter used.

We need a way to allow setting writer::Basic output verbosity via CLI, while considering possible custom Writer implementations with or without changing the CLI.
@tyranron tyranron added the enhancement Improvement of existing features or bugfix label Oct 12, 2021
@tyranron tyranron added this to the 0.11 milestone Oct 12, 2021
@ilslv ilslv mentioned this issue Oct 12, 2021
Closed
@tyranron tyranron mentioned this issue Oct 21, 2021
Merged
15 tasks
@tyranron tyranron modified the milestones: 0.11, 0.10 Oct 21, 2021
tyranron added a commit that referenced this issue Oct 25, 2021
@ilslv @tyranron
Redesign and rework CLI (#144, #58, #134, #140)
4fa122a 
- make CLI options  composable by adding `Cli` associated type to `Parser`, `Runner` and `Writer` traits
- switch to `structopt` crate as `clap` doesn't support generic flattening at the moment
- allow extend `cli::Opts` with a custom `StructOpt` deriver

Additionally:
- fix accidenatlly messed up imports style

Co-authored-by: tyranron <tyranron@gmail.com>
@tyranron
Copy link
Member Author

Now, supported with -v, --verbose CLI option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilslv ilslv

Labels
enhancement Improvement of existing features or bugfix
Projects
None yet
Milestone
0.10
Development

No branches or pull requests
2 participants
@tyranron @ilslv