Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing error on feature with comment and tag (#35) #37

Merged
merged 3 commits into from
Oct 24, 2022

Conversation

ilslv
Copy link
Member

@ilslv ilslv commented Oct 24, 2022

Fixes #35
Supersedes #36

Synopsis

Currently parsing fails on:

#comment
@tag
Feature: feature

Solution

The problem is nl() rule currently tries to parse newline and then comment() rule. It leads to a recursion and possible stack overflow and can't parse file, that begins with a comment. Adding a newline to a beginning of the file removes error.

Parse comment first and then newline.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@ilslv ilslv self-assigned this Oct 24, 2022
@ilslv ilslv added the enhancement Improvement of existing features or bugfix label Oct 24, 2022
@ilslv ilslv added this to the 0.13.0 milestone Oct 24, 2022
@ilslv
Copy link
Member Author

ilslv commented Oct 24, 2022

FCM

Fix parsing error on feature with comment and tag (#37, #35)

@tyranron tyranron linked an issue Oct 24, 2022 that may be closed by this pull request
@tyranron tyranron changed the title Fix parsing error on feature with comment and tag Fix parsing error on feature with comment and tag (#35) Oct 24, 2022
@tyranron tyranron merged commit c21fafd into main Oct 24, 2022
@tyranron tyranron deleted the 35-fix-feature-with-comment-and-tag branch October 24, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parsing fails in case of features with comments and tags.
2 participants