Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for upcoming RSpec 4.0 #787

Closed
wants to merge 6 commits into from
Closed

Support for upcoming RSpec 4.0 #787

wants to merge 6 commits into from

Conversation

mvz
Copy link
Contributor

@mvz mvz commented Feb 26, 2021

Summary

Several changes to allow use of Aruba with RSpec 4, and use of Aruba 1.0 to test RSpec 4.

Details

  • Loosen dependency on rspec-expectations so Aruba users can upgrade to RSpec 4 when it comes out.
  • Add back support for Ruby 2.3 to support RSpec's (tentative) wish to support that Ruby version for the 4.x series.

I may split this up later once it becomes clearer whether testing RSpec with cucumber 2, 3 or 4 is possible (currently each of these versions has some problem).

Motivation and Context

See https://github.com/rspec/rspec/issues/61#issuecomment-786505319 and subsequent comments for some discussion.

How Has This Been Tested?

CI for now. Hopefully the new 2.3 build targets will behave.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Internal change (refactoring, test improvements, developer experience or update of dependencies)

Checklist:

  • I've added tests for my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@mvz mvz changed the title WIP: Support for upcoming RSpec 4.0 Support for upcoming RSpec 4.0 Feb 26, 2021
@mvz mvz marked this pull request as draft February 26, 2021 12:41
@mvz mvz force-pushed the support-rspec-4-0 branch 3 times, most recently from 2347130 to 4958c77 Compare February 26, 2021 15:54
@mvz mvz mentioned this pull request Feb 26, 2021
53 tasks
@mvz
Copy link
Contributor Author

mvz commented Jun 21, 2021

Supporting Ruby 2.3 is no longer realistic. I will open a new pull request for Aruba to work with RSpec 4 when it comes out.

@mvz mvz closed this Jun 21, 2021
@mvz mvz deleted the support-rspec-4-0 branch June 21, 2021 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant