Fix minitest setup code and make minitest support scenarios run at least one test #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to how test success is checked, the failure to run at least one test was never noticed. A change in behavior in minitest exposed the problem. See minitest/minitest#986.
|
Another scenario is failing which really should have zero tests run 😢 |
This makes the minitest initializer create a dummy test so - the test code gets exercised on the first run - minitest will output the number of tests run in version 5.22 (see minitest/minitest#986) It also fixes the setup code which was now finally tested and found failing.
This removes some boilerplate closing and reopening of modules.
mvz
changed the title
|
The RuboCop failure will be fixed in a separate pull request. |
This was referenced Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make minitest scenarios run at least one test so test summary is displayed.
Details
This change fixes the name of the test method in the minitest scenario so minitest actually recognizes it as a test. It also updates the setup code which was outdated. This was never noticed because it was not run.
It also updates the minitest initializer so it generates a dummy test, and fixes the test setup that it generates.
Motivation and Context
Due to how test success is checked, the failure to run at least one test was never noticed. A change in behavior in minitest exposed the problem by making nearly all CI jobs fail. See minitest/minitest#986.
How Has This Been Tested?
The failing scenarios now pass.
Types of changes
Checklist: