Change Dockerfile to install .NET 5 SDK #19
Conversation
|
Fantastic! Thanks Gaspar. |
|
We still need mono for Berp, is that right? |
@mattwynne currently yes. But if we recompile Berp for .NET 5, we can also get rid of that, I think. |
|
We'll probably need to do a new release of this image before we merge in cucumber/common#1511 Note that I was half-way through trying to release a 0.2.0 version with the ARM / M1 chip support on Friday but had to stop before I'd finished, so there might be some images with that tag kicking around. You can just overwrite those images if this is ready first. Ref #10 |
|
@mattwynne yes, we need a release of this for cucumber/common#1511. With a release we could also check if the cucumber monorepo can successfully built with it on circle ci. if not (and not easily fixable), we would need to roll back, I guess. The cucumber/common#1511 is not super urgent and anyway in progress, but to check the build status it would be good to kick off the release soon. I guess the ARM/M1 support is going to be a more tricky issue, but hopefully it can benefit from this change. |
|
@mattwynne hold on with the release. I've found a small problem. In the way it is set now, only root can access the |
|
@mattwynne fixed (pushed to master). now works with normal user as well |
The .NET SDK v2.2 that the build currently has is not supported by Microsoft anymore and it has build issues with the .NET Gherkin project on Docker.
I have made some tests and with minimal changes in the monorepo (gherkin/dotnet) it could compile with .NET 5.0 targeting the same platforms (.NET 4.5, .NET Standard 2.0) as before (ie the compilation result remains the same - no compatibility problems).
Hopefully .NET 5 works also better for ARM needed by @ciaranmcnulty for #12.
I built the image locally and was able to compile Gherkin with it (the changes in the monorepo are also needed - that will be a separate PR!)