Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ci-environment implementation in Go #150

Closed
dumpsterfireproject opened this issue Jul 20, 2022 · 0 comments · Fixed by #151
Closed

Add ci-environment implementation in Go #150

dumpsterfireproject opened this issue Jul 20, 2022 · 0 comments · Fixed by #151

Comments

@dumpsterfireproject
Copy link
Contributor

🤔 What's the problem you're trying to solve?

Working on the message formatter for Godog, I noticed there is currently nothing in that project to gather the data for the ci element of the meta message.

✨ What's your proposed solution?

I created an implementation in Go and will be submitting a PR for review shortly. I wanted to have an issue to which I could link the PR.

⛏ Have you considered any alternatives or workarounds?

I considered trying to detect the CI environment information directly in the Godog project. But after seeing the tests and configuration available in this project, it seemed more beneficial to reuse that and stay in line with the java, javascript, and ruby implementations.

📚 Any additional context?

N/A
dumpsterfireproject added a commit that referenced this issue Jul 20, 2022
@dumpsterfireproject
add ci-environment implementation in Go (#150)
3604a41
dumpsterfireproject added a commit that referenced this issue Jul 20, 2022
@dumpsterfireproject
add ci-environment implementation in Go (#150)
97951ca
@dumpsterfireproject dumpsterfireproject mentioned this issue Jul 20, 2022
Merged
7 tasks
dumpsterfireproject added a commit that referenced this issue Jul 20, 2022
@dumpsterfireproject
comment staticcheck (#150)
91f53a7
dumpsterfireproject added a commit that referenced this issue Jul 20, 2022
@dumpsterfireproject
comment code coverage for now, check on using that with multiple lang…
298b219 
…uages (#150)
dumpsterfireproject added a commit that referenced this issue Jul 20, 2022
@dumpsterfireproject
address file name capitalization caught by go vet (#150)
17c70d8
dumpsterfireproject added a commit that referenced this issue Jul 20, 2022
@dumpsterfireproject
the environment variables already present while running in github act…
d2d184b 
…ions had to be accounted for in the tests (#150)
dumpsterfireproject added a commit that referenced this issue Jul 21, 2022
@dumpsterfireproject
changes per code review (#150)
08f6186
aurelien-reeves pushed a commit that referenced this issue Jul 21, 2022
@dumpsterfireproject
150 add ci environment implementation in go (#151)
d0a4a15 
* initial go implementation is green - now refactor

* add ci-environment implementation in Go (#150)

* add ci-environment implementation in Go (#150)

* comment staticcheck (#150)

* comment code coverage for now, check on using that with multiple languages (#150)

* address file name capitalization caught by go vet (#150)

* the environment variables already present while running in github actions had to be accounted for in the tests (#150)

* changes per code review (#150)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

150 add ci environment implementation in go cucumber/ci-environment
1 participant
@dumpsterfireproject