Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commit SHA for GitHub Actions is incorrect for Pull requests #67

Closed
vincent-psarga opened this issue Jan 31, 2022 · 1 comment
Closed

Commit SHA for GitHub Actions is incorrect for Pull requests #67

vincent-psarga opened this issue Jan 31, 2022 · 1 comment

Comments

@vincent-psarga
Copy link
Contributor

Describe the bug

The commit SHA provided in a PR is not the SHA of the last commit in this PR (instead, it's a merge commit between the last commit and the base branch, usually main).

Additional context

Some extra infos and a potential solution here: https://github.community/t/github-sha-not-the-same-as-the-triggering-commit/18286/3
vincent-psarga added a commit that referenced this issue Feb 1, 2022
@vincent-psarga
Javascript: provide correct SHA for GitHub actions (#67)
c90e437
@vincent-psarga vincent-psarga mentioned this issue Feb 1, 2022
Merged
7 tasks
aslakhellesoy added a commit that referenced this issue Mar 4, 2022
@vincent-psarga @aslakhellesoy
Provide correct SHA for GitHub actions (#67) (#69)
fd66dc7 
* Javascript: provide correct SHA for GitHub actions (#67)

* Use new worflow event format

* Linting

* Remove checking SHA in GHA

The idea was to do an acceptance test, but running `git rev-parse HEAD` does not
show the "correct" SHA (it shows the same than the GITHUB_SHA env var)

* Also implement correct SHA for Ruby

* Linting

* Fix CamelCase in Ruby

* Only read event file for pull requests

* Java: Read revision from GITHUB_EVENT_PATH

* Rename

* Update changelog

* Reduce visibility

* Restore empty constructor

Co-authored-by: Aslak Hellesøy <1000+aslakhellesoy@users.noreply.github.com>
Co-authored-by: Aslak Hellesøy <aslak.hellesoy@gmail.com>
@aslakhellesoy
Copy link
Contributor

Fixed by #69

@aslakhellesoy aslakhellesoy mentioned this issue Jul 21, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aslakhellesoy @vincent-psarga