Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby protobuf-cucumber: Cucumber to upstream to protobuf? #1436

Closed
jackorp opened this issue Mar 23, 2021 · 2 comments
Closed

Ruby protobuf-cucumber: Cucumber to upstream to protobuf? #1436

jackorp opened this issue Mar 23, 2021 · 2 comments
Labels
🙅 wontfix This will not be worked on

Comments

@jackorp
Copy link
Contributor

jackorp commented Mar 23, 2021

Summary

While it's not ideal, would you (the maintainers) mind stepping up as protobuf upstream? Regarding relevant discussion in the issue's #1386 comment.

You are the upstream right now for the pure ruby protobuf implementation. I am asking if you see yourself as the defacto upstream since the original project seems inactive.

Another question is how much do the forks actually diverge right now. Is there any added value beyond the mentioned pull requests?

Would you step up

Context & Motivation

Protobuf upstream seems unresponsive since the PRs 411 and 415 related to cucumber-messages have been sitting there for around a year.

I am currently involved in packaging the update for the cucumber ruby gem, and one of the tasks required is packaging protobuf.
The problem is that to make it work with cucumber-messages, I need the patches from PRs (effectively creating my own fork in the form of the package).

Regarding the diverge in the fork vs. upstream, in the case of some security patches I missed when comparing histories that do not have a PR, I'd have to manually backport them, which is too much work in comparison to just packaging the protobuf-cucumber.

@mpkorstanje
Copy link
Contributor

mpkorstanje commented Mar 23, 2021

We are not interested in maintaining ruby protobuf and are looking to replace it in our implementation.

#1386

@aslakhellesoy
Copy link
Contributor

Thanks for reaching out @jackorp - closing this since we'll no longer be using protobuf at all in one of the next releases.

@aslakhellesoy aslakhellesoy added the 🙅 wontfix This will not be worked on label Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙅 wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants