gherkin-perl: Fixes due to testing release infrastructure #1316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gherkin 4.0.0 is what is currently available on CPAN.
The Perl test suite was being tested only on release. Make sure the tests are generally included in test runs.
Peeking at the Java implementation, the current version is `16.0.1-SNAPHOT` and there is an "update-version" rule which is presumably used in the release process.
This code is already in the generated output - no update needed there.
ehuelsmann
added
language: perl
library: gherkin
🔧 build
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes to Makefile as a consequence of testing release rules
Details
The Perl release hasn't been used since 4.0.0. Although I'm not familiar with the procedure, I've tested various rules and looked at the rules from Java and Ruby to see what they're expected to do.
One of the findings from the testing is that there is a Perl test suite (of a single test), which is run on release -- which was broken, because not run on CI. This test has now been fixed and added to the regular test cycle.