Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

messages-perl fixes after Gherkin integration #1727

Merged
merged 5 commits into from
Sep 6, 2021
Merged

Conversation

ehuelsmann
Copy link
Contributor

@ehuelsmann ehuelsmann commented Sep 6, 2021

Summary

Based on integration work into Gherkin/Perl, a few issues were identified that this PR fixes.

Motivation and Context

How Has This Been Tested?

Using my (locally available) integration in Gherkin/Perl.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • The change has been ported to Java.
  • The change has been ported to Ruby.
  • The change has been ported to JavaScript.
  • The change has been ported to Go.
  • The change has been ported to .NET.
  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have updated the CHANGELOG accordingly.

@ehuelsmann ehuelsmann marked this pull request as ready for review September 6, 2021 10:52
@ehuelsmann
Copy link
Contributor Author

Based on @aurelien-reeves's approval, merging.

@ehuelsmann ehuelsmann merged commit 044b289 into main Sep 6, 2021
@ehuelsmann ehuelsmann deleted the update-messages-perl branch September 6, 2021 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants