Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gherkin-perl] Add module documentation for public API #1740

Merged
merged 3 commits into from Sep 9, 2021

Conversation

ehuelsmann
Copy link
Contributor

Summary

Add missing API documentation.

Details

Now that the Gherkin/Perl modules are on target (i.e. based on Cucumber::Messages), we'd like people to actually be able to use these modules. Documentation is paramount to that goal.

Motivation and Context

Why, if we don't want to document the modules, would we even go through the trouble publishing them?

How Has This Been Tested?

The documentation itself has not; the tests have been run to verify no new regressions.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • The change has been ported to Java.
  • The change has been ported to Ruby.
  • The change has been ported to JavaScript.
  • The change has been ported to Go.
  • The change has been ported to .NET.
  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have updated the CHANGELOG accordingly.

Copy link
Contributor

@aurelien-reeves aurelien-reeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! 🤩

We should consider documenting all implementations this way!

@ehuelsmann
Copy link
Contributor Author

Thanks for the review!

@ehuelsmann ehuelsmann merged commit ed1eeb4 into main Sep 9, 2021
@ehuelsmann ehuelsmann deleted the update-gherkin-perl branch September 9, 2021 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 documentation Improvements or additions to documentation language: perl library: gherkin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants