gherkin/java: Support reading directly from input #2018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpkorstanje
force-pushed
the
fix-gherkin-docs-java
branch
from
a0e3d6d
to
e27ee90
Compare
Added a `parseGherkinPlain` method to the parser make the readme less ugly.
mpkorstanje
force-pushed
the
fix-gherkin-docs-java
branch
from
01d2b59
to
b751adb
Compare
mpkorstanje
changed the title
This also requires parsing the #encoding: <encoding> pragma in feature files. This is not a standard gherkin feature, but it better done here then in Cucumber-JVM.
Added a `parseGherkinPlain` method to the parser make the readme less ugly.
mpkorstanje
force-pushed
the
fix-gherkin-docs-java
branch
from
e338302
to
9605955
Compare
mpkorstanje
added a commit
to cucumber/cucumber-jvm
that referenced
this pull request
Oct 11, 2022
Previously before handing over a feature file to the Gherkin parser, Cucumber would remove any Byte Order Markers (BOM) and determine the encoding of the feature file based on the `#encoding: <encoding>` comment. With cucumber/common#2018 this can now be handled by Gherkin. Removing it simplifies Cucumber a little. Unfortunately the `FeatureParser` doesn't take a `InputStream` as an argument. So we need to add a default interface to avoid breaking semver.
7 tasks
mpkorstanje
added a commit
to cucumber/cucumber-jvm
that referenced
this pull request
Oct 11, 2022
Previously before handing over a feature file to the Gherkin parser, Cucumber would remove any Byte Order Markers (BOM) and determine the encoding of the feature file based on the `#encoding: <encoding>` comment. With cucumber/common#2018 this can now be handled by Gherkin. Removing it simplifies Cucumber a little. Unfortunately the `FeatureParser` doesn't take a `InputStream` as an argument. So we need to add a default interface to avoid breaking semver.
mpkorstanje
added a commit
to cucumber/cucumber-jvm
that referenced
this pull request
Oct 11, 2022
Previously before handing over a feature file to the Gherkin parser, Cucumber would remove any Byte Order Markers (BOM) and determine the encoding of the feature file based on the `#encoding: <encoding>` comment. With cucumber/common#2018 this can now be handled by Gherkin. Removing it simplifies Cucumber a little. Unfortunately the `FeatureParser` doesn't take a `InputStream` as an argument. So we need to add a default interface to avoid breaking semver.
mpkorstanje
added a commit
to cucumber/cucumber-jvm
that referenced
this pull request
Oct 12, 2022
Previously before handing over a feature file to the Gherkin parser, Cucumber would remove any Byte Order Markers (BOM) and determine the encoding of the feature file based on the `#encoding: <encoding>` comment. With cucumber/common#2018 this can now be handled by Gherkin. Removing it simplifies Cucumber a little. Unfortunately the `FeatureParser` doesn't take a `InputStream` as an argument. So we need to add a default interface to avoid breaking semver.
mpkorstanje
added a commit
to cucumber/cucumber-jvm
that referenced
this pull request
Oct 12, 2022
Previously before handing over a feature file to the Gherkin parser, Cucumber would remove any Byte Order Markers (BOM) and determine the encoding of the feature file based on the `#encoding: <encoding>` comment. With cucumber/common#2018 this can now be handled by Gherkin. Removing it simplifies Cucumber a little. Unfortunately the `FeatureParser` doesn't take a `InputStream` as an argument. So we need to add a default interface to avoid breaking semver.
mpkorstanje
added a commit
to cucumber/cucumber-jvm
that referenced
this pull request
Oct 12, 2022
Previously before handing over a feature file to the Gherkin parser, Cucumber would remove any Byte Order Markers (BOM) and determine the encoding of the feature file based on the `#encoding: <encoding>` comment. With cucumber/common#2018 this can now be handled by Gherkin. Removing it simplifies Cucumber a little. Unfortunately the `FeatureParser` doesn't take a `InputStream` as an argument. So we need to add a default interface to avoid breaking semver.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Support reading directly from input such a paths and input streams.
This also requires parsing the #encoding: pragma in feature files.
This is not a standard gherkin feature, but it better done here then in
Cucumber-JVM.