cucumber-messages-dotnet: Set Target Framework to net45 and netstandard2.0 #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SabotageAndi
approved these changes
May 6, 2019
|
Hi @david1995, Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾 In return for this generous offer we hope you will:
On behalf of the Cucumber core team, |
SabotageAndi
pushed a commit
that referenced
this pull request
May 7, 2019
…rd2.0 (#608) * improve gitignore * update solution * update packages * update target frameworks * use Grpc.Tools for generating Protobuf code files * remove generation of Messages.cs from makefile * add netfx.props * move messages.proto into Cucumber.Messages * add directory.build.props * update Cucumber.Messages project file * update solution file * update Grpc.Tools package * update default.mk * add .travis.yml file * move messages.proto in root directory again
SabotageAndi
pushed a commit
that referenced
this pull request
Jun 14, 2019
…rd2.0 (#608) * improve gitignore * update solution * update packages * update target frameworks * use Grpc.Tools for generating Protobuf code files * remove generation of Messages.cs from makefile * add netfx.props * move messages.proto into Cucumber.Messages * add directory.build.props * update Cucumber.Messages project file * update solution file * update Grpc.Tools package * update default.mk * add .travis.yml file * move messages.proto in root directory again
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Set the target framework to net45 and netstandard2.0 for cucumber-messages for .NET.
In addition, generating the Protobuf code-behind file is now integrated into MSBuild.
Details
Replace existing .gitignore with Visual Studio .gitignore
Add Grpc.Tools package to Cucumber.Messages
Generate Messages.cs via MSBuild to enable development under Windows
Set Target Frameworks to net45;netstandard2.0 in Cucumber.Messages
Motivation and Context
Support for Cucumber messages when using .NET 4.5 or .NET Standard 2.0
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: