Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gherkin: Do not trim leading newlines #891

Merged
merged 17 commits into from
Feb 7, 2020
Merged

gherkin: Do not trim leading newlines #891

merged 17 commits into from
Feb 7, 2020

Conversation

mpkorstanje
Copy link
Contributor

@mpkorstanje mpkorstanje commented Feb 7, 2020 •
edited

Summary

Fixes: #290

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • The change has been ported to Java.
  • The change has been ported to Ruby.
  • The change has been ported to JavaScript.
  • The change has been ported to Go.
  • I've added tests for my code.
  • I have updated the CHANGELOG accordingly.

@mpkorstanje mpkorstanje changed the title Do not trim leading newlines gherkin: Do not trim leading newlines Feb 7, 2020
@mpkorstanje mpkorstanje marked this pull request as ready for review February 7, 2020 23:07
@mpkorstanje mpkorstanje merged commit ae0cf6f into master Feb 7, 2020
@mpkorstanje mpkorstanje deleted the fix-trimmed-newlines branch February 7, 2020 23:43
@mpkorstanje mpkorstanje mentioned this pull request May 22, 2020
Merged
12 tasks
Ajwah pushed a commit to Ajwah/ex-gherkin that referenced this pull request Jul 23, 2020
@kevin-johnson-shopify
Update testdata
ef66980 
In the past 6 months, `cucumber/cucumber`-repo has seen a variet of
changes all of which have been fixed with this commit:
  * background to have `id`
  * rule to have `id`
  * examples to have `id`
  * ensure to only strip leading and trailing spaces in table cells.
  Keep newline intact
  * ensure escaped delimiter within doc_string is not recorded as escaped
  * doc_string has field change: contentType -> mediaType
  * ignore comments on tags

See:
  cucumber/common#891
  cucumber/common#880
  cucumber/common#889
  cucumber/common#800

At the time of this commit, master for `cucumber/cucumber` was at:
a7c593f479e7ae739b49108f79bba4853352d99c
@Ajwah Ajwah mentioned this pull request Jul 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
library: gherkin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gherkin: Leading and trailing "\n" are trimmed in DataTable cells
1 participant
@mpkorstanje