Fix Issue #399 - fix JumpToStepDefinition and StepHyperlinkDetector for multi-project #411
Conversation
when doing the StepHyperlinkDetector, expand to fetch from all projects, not just the one the gherkin file is from.
nddipiazza
changed the title
nddipiazza
changed the title
don't look for stepdefs in closed projects and ignore failures when trying in case something unexpected happens.
|
@laeubi in our use case, that totally blows up our use of the plugin because our stepdefs span several projects. did you have a situation where this was actually causing a great amount of lag? as far as I can tell, even a 40 sub-project workspace performs fairly well. |
|
Cucumber only uses classes on the classpath to search for step-defs and thus we decided to only search step-defs on project and reference. Simply add the dependent projects as project reference or maven dependencies and it should work. See #302 for example, in fact the current cucumber plugin behaves wrong as it scans all class (that's not why cucumber does) but that's a different story, enhancing this to the whole workspace would not make it any better. |
|
Yeah I saw that code but unfortunately it does not work for references via maven dependency. No one I work with uses the Eclipse project reference stuff, they use maven dependencies and Eclipse automatically handles project references through that. So perhaps that is the real issue here - it's failing to find the project references via maven deps. |
|
Then this must be fixed instead of iterate over all projects in the workspace :-) |
|
@nddipiazza I'm currently completely overhaul the whole plugin and like to consider your problem there, can you share a minimal example that illustrates the problem? |
|
Hi @laeubi ! https://github.com/nddipiazza/cucumber-java-skeleton |
when doing the StepHyperlinkDetector and JumpToStepDefinition , expand to fetch from all
projects in the Eclipse workspace, not just the one the gherkin file is from.