Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try using actions/setup-java cache #480

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Conversation

mattwynne
Copy link
Member

🤔 What's changed?

Use the cache built into the actions/setup-java Github Action.

⚡️ What's your motivation?

Speed up the build. The existing cache doesn't seem to work, and adds complexity to the build script that maybe we don't need anymore.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)

♻️ Anything particular you want feedback on?

I want to just let it run and see if it improves the build time.

📋 Checklist:


This text was originally generated from a template, then edited by hand. You can modify the template here.

Since the other one doesn't seem to be working, judging from the speed of the builds.
Copy link
Contributor

@laeubi laeubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But actually this is doing almost the same (just less configuration).

@mattwynne mattwynne merged commit 1a5c0b7 into main Nov 14, 2022
@mpkorstanje mpkorstanje deleted the try-different-maven-cache branch November 14, 2022 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants