Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stricter type checking and eslint config #16

Merged
merged 7 commits into from Sep 28, 2021

Conversation

aslakhellesoy
Copy link
Contributor

Description

Add stricter type checking and eslint config

Motivation & context

It makes the code more type-safe, both internally and at the API level

Type of change

  • Refactoring/debt (improvement to code design or tooling without changing behaviour)
  • Breaking change (will cause existing functionality to not
    work as expected)

Remember to add an entry to the relevant section of CHANGELOG.md as part of this pull request.

Note to other contributors

If your change may impact future contributors, explain it here, and remember to update README.md and CONTRIBUTING.md accordingly.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aslakhellesoy
Copy link
Contributor Author

There are some breaking changes in here - we need to update the changelog

@aslakhellesoy aslakhellesoy merged commit 5af7076 into main Sep 28, 2021
@aslakhellesoy aslakhellesoy deleted the typescript-type-safety-and-eslint branch September 28, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants