Skip to content

Commit

Permalink
put quotes around the absolute path (#1845)
Browse files Browse the repository at this point in the history
added quotes to wrap the path to summary.txt
to ensure that paths containing spaces are read properly

Co-authored-by: Matt Wynne <matt@cucumber.io>
Co-authored-by: Blaise Pabon <blaise@gmail.com>
Co-authored-by: Dane Parchment <dparchmentjr@gmail.com>
  • Loading branch information
4 people committed Nov 19, 2021
1 parent 9f03c2f commit 066a0bd
Showing 1 changed file with 7 additions and 6 deletions.
13 changes: 7 additions & 6 deletions features/formatter_paths.feature
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,15 @@ Feature: Formatter Paths
Background:
Given a file named "features/a.feature" with:
"""
Feature: some feature
Scenario: some scenario
Given a passing step
Feature: some feature
Scenario: some scenario
Given a passing step
"""
And a file named "features/step_definitions/cucumber_steps.js" with:
"""
const {Given} = require('@cucumber/cucumber')
const {Given} = require('@cucumber/cucumber')
Given(/^a passing step$/, function() {})
Given(/^a passing step$/, function() {})
"""

Scenario: Relative path
Expand All @@ -23,9 +23,10 @@ Feature: Formatter Paths
<duration-stat>
"""

@wip
Scenario: Absolute path
Given "{{{tmpDir}}}" is an absolute path
When I run cucumber-js with `-f summary:{{{tmpDir}}}/summary.txt`
When I run cucumber-js with `-f summary:"{{{tmpDir}}}/summary.txt"`
Then the file "{{{tmpDir}}}/summary.txt" has the text:
"""
1 scenario (1 passed)
Expand Down

0 comments on commit 066a0bd

Please sign in to comment.