New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create new cucumber package depending on @cucumber/cucumber #1440
Comments
I guess the downside of this is that if users installed it, they'd have to change their support code to import from the new package, and their IDE/linter may then get mad at them for importing something that's not a direct dependency. An alternative might be to release a 6.0.6 or 6.1.0 (for dependabot and friends to still kick in) and then npm deprecate it with a message pointing to a blog post or similar. I think I've seen this done before. Don't feel strongly though! |
Oh I wasn't aware of the deprecate feature. Yes, that would be better. I'm not sure what we could possibly release though. Maybe just a That sounds better. Suggested message:
|
I am updating the migration guide in |
Message LGTM. We could show at runtime as well similar to how we now do with the publish banner? |
I think as a post-installation message is sufficient. Gotta be careful not to be too noisy! |
@davidjgoss @charlierudolph how about something like this? https://github.com/cucumber/cucumber-js-package-upgrade/ It prints the README in the console (with some highlighting) after installation, but also at runtime. It's a bit noisy, but I think that's ok since it is a major version they will only stay at for a short moment. I think this needs to be a major release. Releasing it as 6.0.3 or 6.1.0 would break semver as it is not backwards compatible. With 7.0.0 they will at least expect breakages. |
I've installed this as a
I'll go ahead and release this so people on |
Done! https://www.npmjs.com/package/cucumber/v/7.0.0-rc.0 Let's release another one when we make 7.0.0 final (as well as any RC releases in-between). The release process is the same as for cucumber-js. |
I've deprecated it too:
|
This is to make sure people who rely on dependabot, renovate and the like get notifications about the new version.
It should have a post-install message encouraging people to change to
@cucumber/cucumber
We should release this for every 7 RC, as well as the first final 7.
The text was updated successfully, but these errors were encountered: