Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

peer dependency not fulfilled in latest release #2005

Closed
travi opened this issue Apr 20, 2022 · 0 comments · Fixed by #2006
Closed

peer dependency not fulfilled in latest release #2005

travi opened this issue Apr 20, 2022 · 0 comments · Fixed by #2006

Comments

@travi
Copy link
Member

travi commented Apr 20, 2022

👓 What did you see?

i've been getting renovate PRs for the latest release (v8.1.0). when running npm ls to ensure that all peer dependency requirements are met (i run this as part of my standard verification for most projects), it fails reporting:

npm ERR! peer dep missing: @cucumber/message-streams@>=4.0.0, required by @cucumber/gherkin-streams@5.0.1

(example failure)

✅ What did you expect to see?

npm ls should exit with an exit code of zero and not report missing peer dependencies. ideally the @cucumber/cucumber package should declare a direct dependency on the @cucumber/message-streams package so that the peer requirement is not passed along to consumers of @cucumber/cucumber

📦 Which tool/library version are you using?

@cucumber/cucumber v8.1.0

🔬 How could we reproduce it?

📚 Any additional context?


This text was originally generated from a template, then edited by hand. You can modify the template here.

travi added a commit to travi/cucumber-js that referenced this issue Apr 20, 2022
davidjgoss added a commit that referenced this issue Apr 20, 2022
…reams peer requirement for consumers (#2006)

* fix(message-streams): defined direct dependency to satisfy gherkin-streams peer requirement for consumers

closes #2005

* docs(changelog): mentioned satisfying of peer requirement by depending on massage-streams

* Update CHANGELOG.md

* Update dependency-lint.yml

* Update dependency-lint.yml

Co-authored-by: David Goss <david@davidgoss.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant