Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cucumber.js v0.4.3 sometimes skips scenario outlines. #245

Closed
jwoudenberg opened this issue Sep 12, 2014 · 8 comments
Closed

Cucumber.js v0.4.3 sometimes skips scenario outlines. #245

jwoudenberg opened this issue Sep 12, 2014 · 8 comments

Comments

@jwoudenberg
Copy link

We noticed that in v0.4.3 certain scenario outlines are skipped. They are not marked as failing or pending steps, but simply excluded from the test output (checked with both the json and pretty formatter), giving the impression that all tests ran succesfully when, in fact, some were skipped.

I have built a small test-case to demonstrate the bug, which can be found here. Please check and run the scenario. Scenario two is recognized, but the step in it is not. Weirdly, removing an additional line from the example table of the Scenario one makes Scenario two run properly.

@jbpros jbpros added the bug label Sep 12, 2014
@jbpros
Copy link
Member

jbpros commented Sep 12, 2014

Wow, thanks for reporting this.

@simondean can you take a look at this as you worked a lot on scenario outlines?

@simondean
Copy link
Contributor

@jwoudenberg could you provide a copy of the JSON output for the test case? Thanks

@jbpros jbpros closed this as completed in 3072661 Sep 12, 2014
@jbpros
Copy link
Member

jbpros commented Sep 12, 2014

@simondean it was a bug in Cucumber.Type.Collection#syncForEach and it's fixed now.

@jlin412
Copy link

jlin412 commented Sep 12, 2014

@jbpros When you say fixed, is it updated in 0.4.3 version or further version?

@jbpros
Copy link
Member

jbpros commented Sep 12, 2014

@jlin412 it's been released a few minutes ago in 0.4.4.

@simondean
Copy link
Contributor

Thanks for fixing it @jbpros!

@jwoudenberg
Copy link
Author

That was quick. Thanks!

@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants