Cli.run callback is not called when cucumber-js itself fails

[efokschaner]

This issue repro's when another issue such as this one occurs #564

See problem 2 in https://github.com/efokschaner/cucumber-js-fails-when-step-error-is-not-exception for a full write up, summarized here:

When cucumber-js has an internal error, it does not call the callback passed to Cli.run, leaving the caller unaware of failure. With blocking or callback steps this causes an unhandled exception. With Promise steps, this causes an unhandled rejection, which is not fatal and can leave the program hanging. As an example of real impact, this affects the following project: https://github.com/midniteio/multi-cuke/blob/v0.6.5/src/lib/worker.js where it performs multiple cucumber.Cli runs in forked node processes to parallelise testing. When the unhandled rejection occurs the worker does not know that cucumber has stopped executing.

[charlierudolph]

Thank you for the excellent write up! I actually ran into problem 1 for the first time today, and am good with your proposed solution. Problem 2 is quite tough to deal with, I like the idea of switching to promises

[charlierudolph]

In 2.0.0-rc.1 cucumber cli.run now returns a promise which resolves with a boolean and rejects if there is an internal error.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.