Use cross-platform symbols #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| characters[Cucumber.Status.AMBIGUOUS] = '✖'; | ||
| characters[Cucumber.Status.FAILED] = '✖'; | ||
| characters[Cucumber.Status.PASSED] = '✓'; | ||
| characters[Cucumber.Status.AMBIGUOUS] = figures.warning; |
There was a problem hiding this comment.
Please keep this as figures.cross. Failed and ambiguous are both treated as "Failures" in the summary output so I'd like them to use the same symbol
|
Very cool. Thanks for this @kevgo. I want to setup appveyor anyway so we can make sure things are working for windows. |
|
All comments addressed |
|
Btw please check out https://github.com/Originate/exo-add for a working example of a Node code base on AppVeyor. In particular:
|
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@charlierudolph
Some Windows shells only support a limited character set. Using figures makes the new unicode output of Cucumber more compatible across all platforms.