Trim paths from @rerun files #660
Conversation
| When I run cucumber.js with `-f json @rerun.txt` | ||
| Then the exit status should be 0 | ||
|
|
||
| Scenario: empty rerun file |
There was a problem hiding this comment.
This is a change in behavior. Previously an empty rerun file also ran all the feature files in the current directory
| When I run cucumber.js with `-f json @rerun.txt` | ||
| Then the exit status should be 0 | ||
|
|
||
| Scenario: empty rerun file |
There was a problem hiding this comment.
I agree with this change in functionality.
|
|
||
| """ | ||
| When I run cucumber.js with `-f json @rerun.txt` | ||
| Then the exit status should be 0 |
There was a problem hiding this comment.
Please also check which scenarios ran.
| Scenario: empty rerun file | ||
| Given a file named "@rerun.txt" with: | ||
| """ | ||
| """ |
There was a problem hiding this comment.
Please create a new step (or use an existing step if it exists) so this can read something like:
Given an empty file named "@rerun.txt"| """ | ||
| """ | ||
| When I run cucumber.js with `-f json @rerun.txt` | ||
| Then the exit status should be 0 |
There was a problem hiding this comment.
Please also check that no scenarios run.
| @@ -11,7 +11,8 @@ function Configuration(options, args) { | |||
| var filename = path.basename(arg); | |||
| if (filename[0] === '@') { | |||
| var content = fs.readFileSync(arg, 'utf8'); | |||
| unexpandedFeaturePaths = unexpandedFeaturePaths.concat(content.split('\n')); | |||
| var paths = content.split('\n').map(_.trim).filter(_.identity); | |||
There was a problem hiding this comment.
I'd prefer we use _.compact instead of filter(_.identify). Could also use lodash's _.chain in order to keep it as readable as it if now.
There was a problem hiding this comment.
Nice catch on _.compact!
|
Thanks @haroldhues! Sorry it took me so long to get back to this |
|
Just a heads up @haroldhues I ended up reverting the empty rerun file behavior to run all features instead of nothing. |
|
@charlierudolph Just curious, why revert the change in behavior for the empty file? |
|
Mainly thought it was better to run all tests then no tests. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Fixes #657. This prevents all the tests from running when there is a trailing newline in the rerun file.