Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type tag with 'scenario' as value added to scenario element #893

Merged
merged 1 commit into from
Aug 11, 2017

Conversation

szymonprz
Copy link
Contributor

Hello,
I want to use jenkins to generate report from json file generated by JsonFormatter. We're using https://github.com/jenkinsci/cucumber-reports-plugin to generate cucumber reports on jenkins, but to do that "type" tag for scenario is required to identify element as scenario.

@charlierudolph
Copy link
Member

Why is the type tag needed? Currently there is no other type of element exported via the JSON formatter

@szymonprz
Copy link
Contributor Author

To distinguish scenario from background. Current json formatter should be compatible with json formatters for other cucumber implementations. The output from json formatter should be like here from relish json formatter https://relishapp.com/cucumber/cucumber/docs/formatters/json-output-formatter

@charlierudolph charlierudolph merged commit 44b2cb9 into cucumber:master Aug 11, 2017
@aslakhellesoy
Copy link
Contributor

Hi @szymonprz,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for we ask you to:

  • ✅ Please continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

@charlierudolph
Copy link
Member

Thanks!

@manu7691
Copy link

manu7691 commented Aug 14, 2017

Is it possible to add this PR to v2.3.2 @charlierudolph ? Thanks in advance

@szymonprz szymonprz deleted the type-tag-inside-scenario branch August 22, 2017 16:45
@lock
Copy link

lock bot commented Oct 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants