Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add CODEOWNERS #1990

Merged
merged 2 commits into from
Apr 11, 2022
Merged

chore: add CODEOWNERS #1990

merged 2 commits into from
Apr 11, 2022

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Apr 8, 2022

🤔 What's changed?

Add CODEOWNERS file that declares people on the build team must be involved in any changes under .github/.

Commonly this file is in the root, but it's supported in here as well and this way the file itself is included in the restrictions.

⚡️ What's your motivation?

As discussed in a recent call, we want to minimise security exposure around release workflows being changed by any committers.

Next step is to see if we can tie this up with branch protection as is hinted at in the docs:
https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#codeowners-and-branch-protection

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@coveralls
Copy link

coveralls commented Apr 8, 2022

Coverage Status

Coverage remained the same at 98.232% when pulling 4024db3 on codeowners-pocs into a76ee83 on main.

@davidjgoss davidjgoss merged commit f26ce3e into main Apr 11, 2022
@davidjgoss davidjgoss deleted the codeowners-pocs branch April 11, 2022 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants