Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework time interfaces to avoid using sinon types #2142

Merged
merged 2 commits into from Sep 20, 2022

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Sep 20, 2022

🤔 What's changed?

Rework time interfaces to avoid using sinon types in production code.

⚡️ What's your motivation?

Fixes #2141. We shouldn't have a non-dev dependency, explicit or otherwise, on a test library's types.

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@coveralls
Copy link

coveralls commented Sep 20, 2022

Coverage Status

Coverage remained the same at 98.253% when pulling 6d073e6 on fix/time-types-exposure into 1a3828d on main.

@davidjgoss davidjgoss merged commit e795ae7 into main Sep 20, 2022
@davidjgoss davidjgoss deleted the fix/time-types-exposure branch September 20, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing type definition for @sinon/fake-timers
2 participants