Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include original coordinates in support code library #2197

Merged
merged 7 commits into from Dec 15, 2022

Conversation

davidjgoss
Copy link
Contributor

🤔 What's changed?

Always initialise the support code library with original coordinates so it can be loaded again in child processes.

Previously, when using the API, calling loadSupport and using the result in runCucumber with the parallel option would result in a state where:

  • The parent (coordinator) process has the support code loaded
  • It is happy for test cases to run since it can see they have matching step definitions
  • The child processes don't have the coordinates, so they don't load the support code

And this would be followed by obscure errors as noted in the linked issue.

⚡️ What's your motivation?

Fixes #2196.

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@coveralls
Copy link

coveralls commented Dec 14, 2022

Coverage Status

Coverage increased (+0.01%) to 98.329% when pulling e8b9476 on fix/parallel-loadsupport into c2227ed on main.

@davidjgoss davidjgoss merged commit 8b89a9c into main Dec 15, 2022
@davidjgoss davidjgoss deleted the fix/parallel-loadsupport branch December 15, 2022 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when using parallel
2 participants