Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace duration with luxon for formatting #2204

Merged
merged 3 commits into from Dec 28, 2022
Merged

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Dec 28, 2022

πŸ€” What's changed?

Removes duration as a library for formatting a duration, and replace with luxon.

Also looked at date-fns, being the other of the big two date handling libraries these days, but its functionality for formatting durations didn't match what we need here.

⚑️ What's your motivation?

Fixes #2160. The old library was unmaintained and had a transitive dependency vulnerability.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)
  • πŸ› Bug fix (non-breaking change which fixes a defect)

πŸ“‹ Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@coveralls
Copy link

coveralls commented Dec 28, 2022

Coverage Status

Coverage: 98.335%. Remained the same when pulling ec10bc1 on feat/durations-rework into 01a929c on main.

@davidjgoss davidjgoss merged commit f741cb7 into main Dec 28, 2022
@davidjgoss davidjgoss deleted the feat/durations-rework branch December 28, 2022 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Malware in dependency lib
3 participants