Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(junit): could not generate xml if error message has invalid character #2228

Merged
merged 2 commits into from Feb 3, 2023

Conversation

zcmgyu
Copy link
Contributor

@zcmgyu zcmgyu commented Feb 2, 2023

🤔 What's changed?

Added invalidCharReplacement option in XML Builder in XML formatter

⚡️ What's your motivation?

I could not generate an XML report file via the JUnit formatter setting if the message of a failed test case contains any invalid character (Eg: \x08). So, in order to prevent these cases I added invalidCharReplacement option for XML builder as this documentation.

Screen Shot 2023-02-02 at 16 42 28

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

♻️ Anything particular you want feedback on?

Feel free to suggest any change or possible improvement.

📋 Checklist:

@coveralls
Copy link

coveralls commented Feb 2, 2023

Coverage Status

Coverage: 98.563%. Remained the same when pulling 2a72c0d on zcmgyu:replace-invalid-char-in-junit-xml into 0a2d8dc on cucumber:main.

Copy link
Contributor

@davidjgoss davidjgoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much @zcmgyu!

@davidjgoss davidjgoss merged commit dcf3269 into cucumber:main Feb 3, 2023
@aslakhellesoy
Copy link
Contributor

Hi @zcmgyu,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

@zcmgyu zcmgyu deleted the replace-invalid-char-in-junit-xml branch February 3, 2023 16:51
@davidjgoss
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants