Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refer to example location not outline location in json formatter #2236

Merged
merged 6 commits into from Feb 11, 2023

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Feb 11, 2023

🤔 What's changed?

In the JSON formatter, use the line from the last referenced AST node to refer to examples from a scenario outline. In these cases there are two nodes referenced - one for the outline and one for the example.

⚡️ What's your motivation?

Fixes #2223.

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@coveralls
Copy link

coveralls commented Feb 11, 2023

Coverage Status

Coverage: 98.563%. Remained the same when pulling 306c8d7 on fix/json-formatter-examples-location into cd50dc2 on main.

@davidjgoss davidjgoss merged commit 93ee7ee into main Feb 11, 2023
@davidjgoss davidjgoss deleted the fix/json-formatter-examples-location branch February 11, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scenario Outline json output no longer indicates which example
2 participants