Base64 encode string literals in JsonFormatter #2261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badeball
commented
Mar 20, 2023
davidjgoss
approved these changes
Oct 7, 2023
badeball
added a commit
to badeball/cypress-cucumber-preprocessor
that referenced
this pull request
Nov 2, 2023
This in particular contains a fix for attachments [1]. [1] cucumber/cucumber-js#2261
badeball
added a commit
to badeball/cypress-cucumber-preprocessor
that referenced
this pull request
Nov 2, 2023
* Nearly all, except some packages that have migrated to ESM and are more diffult to update, in addition to prettier, for which the associated extension remains behind [1] This in particular contains a fix for attachments [2]. [1] prettier/prettier-vscode@ad1d008 [2] cucumber/cucumber-js#2261
badeball
added a commit
to badeball/cypress-cucumber-preprocessor
that referenced
this pull request
Nov 2, 2023
* Nearly all, except some packages that have migrated to ESM and are more diffult to update, in addition to prettier, for which the associated extension remains behind [1]. This in particular contains a fix for attachments [2]. [1] prettier/prettier-vscode@ad1d008 [2] cucumber/cucumber-js#2261
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
This fixes #2260.
This ensures that all embeddings in JSON reports are base64-encoded. This is also how cucumber-json-formatter interprets
IDENTITYstrings.⚡️ What's your motivation?
In the JSON output, it's currently impossible to differentiate between strings that were attached as literals vs. those that were base64-encoded to begin with.
🏷️ What kind of change is this?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.