Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support attachments with filenames #2297

Merged
merged 13 commits into from Jul 12, 2023
Merged

support attachments with filenames #2297

merged 13 commits into from Jul 12, 2023

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Jul 8, 2023

🤔 What's changed?

Add support for providing an optional filename for attachments, which is emitted as part of the attachment message and thus can be used in formatters.

To achieve this, we make the second argument to this.attach an options object, with backwards compatibility so a media type string still works as before.

⚡️ What's your motivation?

Follow the cross-platform standards.

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@coveralls
Copy link

coveralls commented Jul 8, 2023

Coverage Status

coverage: 98.505% (+0.006%) from 98.499% when pulling b1804d4 on feat/attachment-filenames into 0518bb3 on main.

@davidjgoss davidjgoss marked this pull request as ready for review July 12, 2023 11:44
@davidjgoss davidjgoss merged commit aea9e8b into main Jul 12, 2023
10 checks passed
@davidjgoss davidjgoss deleted the feat/attachment-filenames branch July 12, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants