Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade html-formatter for attachment improvements #2300

Merged
merged 3 commits into from Jul 14, 2023

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Jul 13, 2023

🤔 What's changed?

Upgrade to the latest html-formatter.

⚡️ What's your motivation?

Brings in ability to download attachments like PDFs that aren't viewable directly in the report - see cucumber/react-components#333

Fixes #2277.

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@davidjgoss davidjgoss changed the title upgrade html-formatter upgrade html-formatter for attachment improvements Jul 13, 2023
@davidjgoss davidjgoss marked this pull request as ready for review July 13, 2023 20:09
@coveralls
Copy link

coveralls commented Jul 13, 2023

Coverage Status

coverage: 98.505%. remained the same when pulling 6321443 on html-formatter-20-4-0 into aea9e8b on main.

@davidjgoss davidjgoss merged commit 12f6bac into main Jul 14, 2023
10 checks passed
@davidjgoss davidjgoss deleted the html-formatter-20-4-0 branch July 14, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for pdf attachments
2 participants