Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove cucumber reports suggestion #2311

Merged
merged 11 commits into from Aug 12, 2023
Merged

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Aug 11, 2023

🤔 What's changed?

Remove the banner that suggests using Cucumber Reports by default.

⚡️ What's your motivation?

The future of this service is uncertain, so we shouldn't be proactively advertising it at this point.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)

♻️ Anything particular you want feedback on?

The --publish-quiet option has not been removed, but is deprecated and will be removed in a major release.

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@davidjgoss davidjgoss changed the title remove code that prints banner fix: remove cucumber reports suggestion Aug 11, 2023
@coveralls
Copy link

coveralls commented Aug 12, 2023

Coverage Status

coverage: 98.456% (-0.05%) from 98.505% when pulling 2afad80 on fix/remove-publish-nag into f1d91d5 on main.

@davidjgoss davidjgoss marked this pull request as ready for review August 12, 2023 10:19
@davidjgoss davidjgoss merged commit 6dc975d into main Aug 12, 2023
10 checks passed
@davidjgoss davidjgoss deleted the fix/remove-publish-nag branch August 12, 2023 11:20
@davidjgoss
Copy link
Contributor Author

badeball added a commit to badeball/cypress-cucumber-preprocessor that referenced this pull request Aug 28, 2023
badeball added a commit to badeball/cypress-cucumber-preprocessor that referenced this pull request Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants