Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better formats config #2318

Merged
merged 6 commits into from Sep 3, 2023
Merged

better formats config #2318

merged 6 commits into from Sep 3, 2023

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Aug 31, 2023

🤔 What's changed?

Expressing formats like "html:./report.html" is painful to read and write, and difficult for us to process. It gets worse when you want to include things that have colons, like URLs and Windows absolute file paths, some of which we struggle to support smartly. It's unavoidable on the CLI but in a configuration file we can make it easier.

This PR adds support for a two-item array notation for format items, so for the above example you could instead do ["html", "./report.html"].

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@davidjgoss davidjgoss changed the title Feat/better formats config better formats config Aug 31, 2023
@davidjgoss davidjgoss marked this pull request as ready for review September 3, 2023 11:10
@davidjgoss davidjgoss merged commit 0a9fad0 into main Sep 3, 2023
10 checks passed
@davidjgoss davidjgoss deleted the feat/better-formats-config branch September 3, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant