Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wait for stream to finish at end of publish plugin #2322

Merged
merged 3 commits into from Sep 3, 2023

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Sep 3, 2023

πŸ€” What's changed?

Await the finish of the stream when cleaning up publish plugin.

⚑️ What's your motivation?

Fixes #2321.

🏷️ What kind of change is this?

  • πŸ› Bug fix (non-breaking change which fixes a defect)

πŸ“‹ Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@davidjgoss davidjgoss marked this pull request as ready for review September 3, 2023 11:37
@davidjgoss davidjgoss merged commit 2c6161e into main Sep 3, 2023
10 checks passed
@davidjgoss davidjgoss deleted the fix/publish-await-finish branch September 3, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish plugin's stream - not ended within runCucumber lifecycle
1 participant