Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade glob #2330

Merged
merged 7 commits into from
Oct 7, 2023
Merged

chore: upgrade glob #2330

merged 7 commits into from
Oct 7, 2023

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Sep 29, 2023

πŸ€” What's changed?

Upgrade glob to the latest version.

This includes some breaking changes from glob that have an effect on us:

  • Results are no longer returned sorted - so we now do a .sort() ourselves on the array
  • Backslashes are no longer considered valid in Windows paths and are interpreted as an escape character - there is a backwards compatibility option for this which we're using - I'd rather just bring users along but it will be quite an involved change and not something we need to do immediately
  • Requires Node.js 18 or above - this means we should land remove support for Node.js 14 and 16Β #2325 before this, although no tests have failed on 14 or 16 interestingly

Nothing breaking for our users, though.

⚑️ What's your motivation?

Fixes #2329 as the vulnerable dependency is no longer present (at least not in production code - you can see via npm ls inflight that some test packages still depend on it, but we can handle that in due course). Also just gets us current.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)
  • πŸ› Bug fix (non-breaking change which fixes a defect)

πŸ“‹ Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@coveralls
Copy link

coveralls commented Sep 29, 2023

Coverage Status

coverage: 97.931% (-0.5%) from 98.458% when pulling 28421d1 on fix/glob-upgrade into 89ec3b6 on main.

@davidjgoss davidjgoss added this to the 10.0.0 milestone Sep 30, 2023
@davidjgoss davidjgoss added the πŸ’” breaking change This will require a major release label Sep 30, 2023
@davidjgoss davidjgoss removed the πŸ’” breaking change This will require a major release label Sep 30, 2023
@davidjgoss davidjgoss changed the title upgrade glob chore: upgrade glob Sep 30, 2023
@davidjgoss davidjgoss marked this pull request as ready for review October 7, 2023 17:14
@davidjgoss davidjgoss merged commit eb1890f into main Oct 7, 2023
6 checks passed
@davidjgoss davidjgoss deleted the fix/glob-upgrade branch October 7, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Veracode security issue for glob@7.2.3 -> inflight@1.0.6
2 participants