Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 5.x #23

Merged
merged 4 commits into from
Apr 20, 2020
Merged

Update to 5.x #23

merged 4 commits into from
Apr 20, 2020

Conversation

gaeljw
Copy link
Member

@gaeljw gaeljw commented Apr 19, 2020

This PR aims to upgrade Cucumber dependency to 5.X, actually 5.6.0.

Content:

  • update code to be compatible with Cucumber 5.6.0
  • added some tests (mainly copied from Cucumber Java)
  • add documentation in README about major changes:
    • move all classes under io.cucumber.scala to be more consistent with Cucumber Java
    • parameters change in Before/After hooks to be consistent with Cucumber Java
  • upgrade Scala versions, Scala Maven plugin and Groovy

The breaking changes are open to discussion but I feel:

Copy link
Contributor

@mpkorstanje mpkorstanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

scala/pom.xml Show resolved Hide resolved
@mpkorstanje mpkorstanje merged commit 47bf9ec into cucumber:master Apr 20, 2020
@aslakhellesoy
Copy link
Contributor

Hi @gaeljw,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

@gaeljw gaeljw deleted the update-to-5.x branch April 20, 2020 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants