Remove the use of the maven-toolchains-plugin (#2595)

To benefit from GitHubs release automation[1] Cucumber should be able to be build on an arbitrary jdk docker image. Typically, these do not provide Maven tool chain configurations. Instead of going through the effort of setting this up in the cucumber/action-publish-mvn we can forge the use of toolchains, simplifying the build process somewhat. To ensure Cucumber is not build with a JDK version less than 11, the enforcer plugin will check this now. Additionally: - Allow spotless and revapi to work in sub modules - Use surefire and failsafe 3.0.0-M7 everywhere - Fix example parent pom versions 1: https://github.com/cucumber/action-publish-mvn
cucumber · Jul 31, 2022 · 1ccc09f · 1ccc09f
1 parent 40af8e6
commit 1ccc09f
Show file tree

Hide file tree

Showing 14 changed files with 100 additions and 125 deletions.
diff --git a/.github/workflows/.toolchains.xml b/.github/workflows/.toolchains.xml
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -31,9 +31,9 @@ jobs:
         with:
           version: '11'
       - name: Install dependencies
-        run: mvn install -DskipTests=true -DskipITs=true -Darchetype.test.skip=true -Dmaven.javadoc.skip=true -B --show-version --toolchains .github/workflows/.toolchains.xml
+        run: mvn install -DskipTests=true -DskipITs=true -Darchetype.test.skip=true -Dmaven.javadoc.skip=true -B --show-version
       - name: Test
-        run: mvn verify --toolchains .github/workflows/.toolchains.xml
+        run: mvn verify
         env:
           CUCUMBER_PUBLISH_TOKEN: ${{ secrets.CUCUMBER_PUBLISH_TOKEN }}
 
@@ -54,9 +54,9 @@ jobs:
         with:
           version: '11'
       - name: Install dependencies
-        run: mvn install -DskipTests=true -DskipITs=true -Darchetype.test.skip=true -Dmaven.javadoc.skip=true --batch-mode --show-version --toolchains .github/workflows/.toolchains.xml
+        run: mvn install -DskipTests=true -DskipITs=true -Darchetype.test.skip=true -Dmaven.javadoc.skip=true --batch-mode --show-version
       - name: Javadoc
-        run: mvn javadoc:jar --toolchains .github/workflows/.toolchains.xml
+        run: mvn javadoc:jar
 
   coverage:
     name: 'Coverage'
@@ -75,9 +75,9 @@ jobs:
         with:
           version: '11'
       - name: Install dependencies
-        run: mvn install -DskipTests=true -DskipITs=true -Darchetype.test.skip=true -Dmaven.javadoc.skip=true --batch-mode --show-version --toolchains .github/workflows/.toolchains.xml
+        run: mvn install -DskipTests=true -DskipITs=true -Darchetype.test.skip=true -Dmaven.javadoc.skip=true --batch-mode --show-version
       - name: Test (Coverage)
-        run: mvn jacoco:prepare-agent verify jacoco:report --toolchains .github/workflows/.toolchains.xml
+        run: mvn jacoco:prepare-agent verify jacoco:report
       - uses: codecov/codecov-action@v3
         with:
           fail_ci_if_error: true
@@ -101,6 +101,6 @@ jobs:
         with:
           version: '11'
       - name: Install dependencies
-        run: mvn install -DskipTests=true -DskipITs=true -Darchetype.test.skip=true -Dmaven.javadoc.skip=true --batch-mode --show-version --toolchains .github/workflows/.toolchains.xml
+        run: mvn install -DskipTests=true -DskipITs=true -Darchetype.test.skip=true -Dmaven.javadoc.skip=true --batch-mode --show-version
       - name: Test (Semver check)
-        run: mvn verify -Pcheck-semantic-version -DskipTests=true -DskipITs=true -Darchetype.test.skip=true --toolchains .github/workflows/.toolchains.xml
+        run: mvn verify -Pcheck-semantic-version -DskipTests=true -DskipITs=true -Darchetype.test.skip=true
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -12,10 +12,10 @@ We appreciate that. Do keep the following in mind:
 
 ## Formatting Java
 
-To automatically format the java source code run
+The source code is formatted automatically by spotless when running:
 
 ```
-mvn initialize spotless:apply
+mvn install
 ```
 
 To configure Intelij IDEA/Eclipse use the configuration files in `.spotless/`.

diff --git a/examples/calculator-java-cli/pom.xml b/examples/calculator-java-cli/pom.xml
@@ -4,7 +4,7 @@
     <parent>
         <groupId>io.cucumber</groupId>
         <artifactId>cucumber-examples</artifactId>
-        <version>7.5.0-SNAPSHOT</version>
+        <version>7.5.1-SNAPSHOT</version>
     </parent>
 
     <artifactId>calculator-java-cli</artifactId>

diff --git a/examples/calculator-java-junit4/pom.xml b/examples/calculator-java-junit4/pom.xml
@@ -4,7 +4,7 @@
     <parent>
         <groupId>io.cucumber</groupId>
         <artifactId>cucumber-examples</artifactId>
-        <version>7.5.0-SNAPSHOT</version>
+        <version>7.5.1-SNAPSHOT</version>
     </parent>
 
     <artifactId>calculator-java-junit4</artifactId>

diff --git a/examples/calculator-java-junit5/pom.xml b/examples/calculator-java-junit5/pom.xml
@@ -4,7 +4,7 @@
     <parent>
         <groupId>io.cucumber</groupId>
         <artifactId>cucumber-examples</artifactId>
-        <version>7.5.0-SNAPSHOT</version>
+        <version>7.5.1-SNAPSHOT</version>
     </parent>
 
     <artifactId>calculator-java-junit5</artifactId>

diff --git a/examples/calculator-java-testng/pom.xml b/examples/calculator-java-testng/pom.xml
@@ -4,7 +4,7 @@
     <parent>
         <groupId>io.cucumber</groupId>
         <artifactId>cucumber-examples</artifactId>
-        <version>7.5.0-SNAPSHOT</version>
+        <version>7.5.1-SNAPSHOT</version>
     </parent>
 
     <artifactId>calculator-java-testng</artifactId>

diff --git a/examples/calculator-java8-cli/pom.xml b/examples/calculator-java8-cli/pom.xml
@@ -4,7 +4,7 @@
     <parent>
         <groupId>io.cucumber</groupId>
         <artifactId>cucumber-examples</artifactId>
-        <version>7.5.0-SNAPSHOT</version>
+        <version>7.5.1-SNAPSHOT</version>
     </parent>
 
     <artifactId>calculator-java8-cli</artifactId>

diff --git a/examples/pom.xml b/examples/pom.xml
@@ -4,7 +4,7 @@
     <parent>
         <groupId>io.cucumber</groupId>
         <artifactId>cucumber-jvm</artifactId>
-        <version>7.5.0-SNAPSHOT</version>
+        <version>7.5.1-SNAPSHOT</version>
     </parent>
 
     <artifactId>cucumber-examples</artifactId>

diff --git a/examples/spring-java-junit5/pom.xml b/examples/spring-java-junit5/pom.xml
@@ -4,7 +4,7 @@
     <parent>
         <groupId>io.cucumber</groupId>
         <artifactId>cucumber-examples</artifactId>
-        <version>7.5.0-SNAPSHOT</version>
+        <version>7.5.1-SNAPSHOT</version>
     </parent>
 
     <artifactId>spring-java-junit5</artifactId>

diff --git a/examples/wicket-java-junit4/pom.xml b/examples/wicket-java-junit4/pom.xml
@@ -3,7 +3,7 @@
     <parent>
         <groupId>io.cucumber</groupId>
         <artifactId>cucumber-examples</artifactId>
-        <version>7.5.0-SNAPSHOT</version>
+        <version>7.5.1-SNAPSHOT</version>
     </parent>
     <artifactId>wicket-java-junit4</artifactId>
     <packaging>pom</packaging>

diff --git a/examples/wicket-java-junit4/wicket-main/pom.xml b/examples/wicket-java-junit4/wicket-main/pom.xml
@@ -3,7 +3,7 @@
     <parent>
         <groupId>io.cucumber</groupId>
         <artifactId>wicket-java-junit4</artifactId>
-        <version>7.5.0-SNAPSHOT</version>
+        <version>7.5.1-SNAPSHOT</version>
     </parent>
     <artifactId>wicket-main</artifactId>
     <name>Examples: Wicket application</name>

diff --git a/examples/wicket-java-junit4/wicket-test/pom.xml b/examples/wicket-java-junit4/wicket-test/pom.xml
@@ -3,7 +3,7 @@
     <parent>
         <groupId>io.cucumber</groupId>
         <artifactId>wicket-java-junit4</artifactId>
-        <version>7.5.0-SNAPSHOT</version>
+        <version>7.5.1-SNAPSHOT</version>
     </parent>
     <artifactId>wicket-test</artifactId>
     <name>Examples: Wicket application tested with Selenium</name>