Skip to content

Commit

Permalink
[Build] Remove warnings caused by the cucumber-archetype
Browse files Browse the repository at this point in the history
  • Loading branch information
mpkorstanje committed Dec 15, 2022
1 parent 9fb0755 commit 3b66ab6
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 5 deletions.
13 changes: 13 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,19 @@ We appreciate that. Do keep the following in mind:
code/output. See [GitHub Flavored Markdown](https://help.github.com/articles/github-flavored-markdown)'s
*Fenced Code Blocks* for details.

## Building

When building the project for the first time, run:

```
mvn install -DskipTests=true -DskipITs=true -Darchetype.test.skip=true
```

The `cucumber-archetype` modules integration tests against `-SNAPSHOT`
versions of Cucumber. These must be installed first.

Afterwards `mvn test` or `mvn verify` should work as expected.

## Formatting Java

The source code is formatted automatically by spotless when running:
Expand Down
10 changes: 5 additions & 5 deletions cucumber-archetype/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,6 @@
<junit-jupiter.version>5.9.1</junit-jupiter.version>
</properties>

<!-- Not used by this module, but used by the integration tests of
created project. Declaring the dependencies keeps the project
in the right order in the maven reactor -->
<dependencyManagement>
<dependencies>
<dependency>
Expand All @@ -30,7 +27,7 @@
<type>pom</type>
<scope>import</scope>
</dependency>
<!-- Also not used by this module. But ensures the junit-jupiter.version
<!-- Not used by this module. But ensures the junit-jupiter.version
in the archetype template is also automatically updated by renovate
bot. -->
<dependency>
Expand All @@ -44,12 +41,15 @@
</dependencyManagement>

<dependencies>
<!-- Also not used by this module, but used by the integration tests of
created project. Declaring the dependencies keeps the project
in the right order in the maven reactor -->
<dependency>
<groupId>io.cucumber</groupId>
<artifactId>cucumber-bom</artifactId>
<version>${project.version}</version>
<type>pom</type>
<scope>import</scope>
<scope>test</scope>
</dependency>
<dependency>
<groupId>io.cucumber</groupId>
Expand Down

0 comments on commit 3b66ab6

Please sign in to comment.