[Core] Remove publish token validation (#2123)

Fixes: #2122
cucumber · Sep 15, 2020 · 538725b · 538725b
1 parent aac6cfb
commit 538725b
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 54 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -17,6 +17,11 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ### Fixed
 
+ * [Core] Validation of `CUCUMBER_PUBLISH_TOKEN` no longer happens inside Cucumber-JVM - only on the server.
+   ([2123](https://github.com/cucumber/cucumber-jvm/pull/2123)
+    [2122](https://github.com/cucumber/cucumber-jvm/issues/2122)
+    Aslak Hellesøy)
+
 ## [6.7.0] (2020-09-14)
 
 ### Added

diff --git a/core/src/main/java/io/cucumber/core/options/CucumberPropertiesParser.java b/core/src/main/java/io/cucumber/core/options/CucumberPropertiesParser.java
@@ -102,7 +102,7 @@ public RuntimeOptionsBuilder parse(Map<String, String> properties) {
 
         parse(properties,
             PLUGIN_PUBLISH_TOKEN_PROPERTY_NAME,
-            PublishTokenParser::parse,
+            s -> s, // No validation - validated on server
             builder::setPublishToken);
 
         parse(properties,

diff --git a/core/src/main/java/io/cucumber/core/options/PublishTokenParser.java b/core/src/main/java/io/cucumber/core/options/PublishTokenParser.java
diff --git a/core/src/test/java/io/cucumber/core/options/PublishTokenParserTest.java b/core/src/test/java/io/cucumber/core/options/PublishTokenParserTest.java
diff --git a/...latform-engine/src/main/java/io/cucumber/junit/platform/engine/CucumberEngineOptions.java b/...latform-engine/src/main/java/io/cucumber/junit/platform/engine/CucumberEngineOptions.java
@@ -4,7 +4,6 @@
 import io.cucumber.core.feature.GluePath;
 import io.cucumber.core.options.ObjectFactoryParser;
 import io.cucumber.core.options.PluginOption;
-import io.cucumber.core.options.PublishTokenParser;
 import io.cucumber.core.options.SnippetTypeParser;
 import io.cucumber.core.plugin.NoPublishFormatter;
 import io.cucumber.core.plugin.PublishFormatter;
@@ -90,7 +89,6 @@ private Optional<PluginOption> getPublishQuitePlugin() {
     private Optional<PluginOption> getPublishTokenPlugin() {
         return configurationParameters
                 .get(PLUGIN_PUBLISH_TOKEN_PROPERTY_NAME)
-                .map(PublishTokenParser::parse)
                 .map(token -> PluginOption.forClass(PublishFormatter.class, token));
     }
 

diff --git a/pom.xml b/pom.xml
@@ -655,6 +655,11 @@
                                     <justification>https://github.com/cucumber/cucumber-jvm/pull/2099</justification>
                                     <newValue>https://messages.cucumber.io/api/reports -X GET</newValue>
                                 </item>
+                                <item>
+                                    <code>java.class.removed</code>
+                                    <old>class io.cucumber.core.options.PublishTokenParser</old>
+                                    <justification>Internal API</justification>
+                                </item>
                             </revapi.ignore>
                         </analysisConfiguration>
                     </configuration>