Skip to content

Commit

Permalink
[Core] Mark Allure 5 and 6 plugins as incompatible (#2652)
Browse files Browse the repository at this point in the history
This bans the use of the incompatible plugins

```
io.qameta.allure.cucumber5jvm.AllureCucumber5Jvm
io.qameta.allure.cucumber6jvm.AllureCucumber6Jvm
```

This will prevent users from making the mistake of using the wrong plugin
version with Cucumber. This avoids questions and noise all around.
  • Loading branch information
mpkorstanje committed Dec 2, 2022
1 parent fc24b11 commit d9a5afd
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Expand Up @@ -13,6 +13,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Added
- Enabled reproducible builds ([2641](https://github.com/cucumber/cucumber-jvm/issues/2641) Hervé Boutemy )
- [Core] Mark Allure 5 and 6 plugins as incompatible ([2652](https://github.com/cucumber/cucumber-jvm/issues/2652) M.P. Korstanje)


## [7.9.0] - 2022-11-01
### Changed
Expand Down
Expand Up @@ -79,6 +79,8 @@ public class PluginOption implements Options.Plugin {
incompatible.add("io.qameta.allure.cucumber2jvm.AllureCucumber2Jvm");
incompatible.add("io.qameta.allure.cucumber3jvm.AllureCucumber3Jvm");
incompatible.add("io.qameta.allure.cucumber4jvm.AllureCucumber4Jvm");
incompatible.add("io.qameta.allure.cucumber5jvm.AllureCucumber5Jvm");
incompatible.add("io.qameta.allure.cucumber6jvm.AllureCucumber6Jvm");
INCOMPATIBLE_PLUGIN_CLASSES = unmodifiableSet(incompatible);
}

Expand Down

0 comments on commit d9a5afd

Please sign in to comment.