Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Execute features files without pickles #1973

Merged
merged 1 commit into from
May 14, 2020

Conversation

mpkorstanje
Copy link
Contributor

A feature without pickles is a valid feature file and should not throw
any exceptions when executed.

An empty feature file is also a valid feature file but we should throw
an exception when explicitly asked to execute it. It was probably a
mistake.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

A feature without pickles is a valid feature file and should not throw
any exceptions when executed.

An empty feature file is also a valid feature file but we should throw
an exception when explicitly asked to execute it. It was probably a
mistake.
@coveralls
Copy link

coveralls commented May 14, 2020

Coverage Status

Coverage remained the same at 85.975% when pulling 1b7b118 on fix-empty-feature-not-found into d840161 on master.

@mpkorstanje mpkorstanje merged commit b40c4f4 into master May 14, 2020
@mpkorstanje mpkorstanje deleted the fix-empty-feature-not-found branch May 14, 2020 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants