Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Extract throwable collector #2281

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Conversation

mpkorstanje
Copy link
Contributor

Try and clean up the logic around throwing/re-throwing exceptions at various
abstraction levels a bit

@mpkorstanje mpkorstanje added this to the v7.0.0 milestone Apr 10, 2021
@aurelien-reeves aurelien-reeves added the 🏦 debt Tech debt label Apr 26, 2021
@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #2281 (4ae0393) into v7.x.x (ebbd4b9) will increase coverage by 0.02%.
The diff coverage is 83.49%.

❗ Current head 4ae0393 differs from pull request most recent head 625f7c2. Consider uploading reports for the commit 625f7c2 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             v7.x.x    #2281      +/-   ##
============================================
+ Coverage     83.31%   83.33%   +0.02%     
- Complexity     2298     2323      +25     
============================================
  Files           291      295       +4     
  Lines          8241     8299      +58     
  Branches        733      737       +4     
============================================
+ Hits           6866     6916      +50     
- Misses         1092     1098       +6     
- Partials        283      285       +2     
Impacted Files Coverage Δ
...n/java/io/cucumber/core/resource/ClassLoaders.java 28.57% <0.00%> (-4.77%) ⬇️
.../cucumber/core/runtime/TestCaseResultObserver.java 45.23% <ø> (ø)
...cumber/core/exception/UnrecoverableExceptions.java 50.00% <50.00%> (ø)
...ber/core/runtime/RethrowingThrowableCollector.java 70.83% <70.83%> (ø)
...io/cucumber/core/runner/TestAbortedExceptions.java 86.66% <86.66%> (ø)
...va/io/cucumber/core/runner/ThrowableCollector.java 88.88% <88.88%> (ø)
.../src/main/java/io/cucumber/core/runner/Runner.java 90.99% <90.90%> (-0.28%) ⬇️
...rc/main/java/io/cucumber/core/runtime/Runtime.java 92.92% <92.30%> (+0.46%) ⬆️
...n/java/io/cucumber/core/plugin/TeamCityPlugin.java 87.87% <100.00%> (ø)
...rc/main/java/io/cucumber/core/runner/TestStep.java 100.00% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebbd4b9...625f7c2. Read the comment docs.

@mpkorstanje mpkorstanje force-pushed the clean-up-exception-handling branch 2 times, most recently from 0d0c082 to a53ae03 Compare August 17, 2021 19:49
Try and clean up the logic around throwing/rethrowing exceptions at various
abstraction levels a bit
@mpkorstanje mpkorstanje marked this pull request as ready for review August 17, 2021 19:59
@mpkorstanje mpkorstanje merged commit 5831903 into v7.x.x Aug 17, 2021
@mpkorstanje mpkorstanje deleted the clean-up-exception-handling branch August 17, 2021 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏦 debt Tech debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants