Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Emit exceptions on failure to handle test run finished events #2651

Merged
merged 1 commit into from Dec 2, 2022

Conversation

mpkorstanje
Copy link
Contributor

@mpkorstanje mpkorstanje commented Nov 27, 2022

馃 What's changed?

The runtime would collect exceptions thrown upon emitting the TestRunFinished
event. The assumption was that these were collected in the test context.
Though this is impossible. The test context is collecting exceptions to include
in the report. So it sits inside the test run started and finished events.

馃搵 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

@mpkorstanje mpkorstanje changed the title [Core] Don't collect exceptions upon emitting TestRunFinished event [Core] Collect exceptions upon emitting TestRunFinished event Nov 27, 2022
@codecov
Copy link

codecov bot commented Nov 27, 2022

Codecov Report

Merging #2651 (e76ad72) into main (d9a5afd) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main    #2651   +/-   ##
=========================================
  Coverage     84.77%   84.77%           
  Complexity     2686     2686           
=========================================
  Files           322      322           
  Lines          9532     9532           
  Branches        903      903           
=========================================
  Hits           8081     8081           
  Misses         1120     1120           
  Partials        331      331           
Impacted Files Coverage 螖
...rc/main/java/io/cucumber/core/runtime/Runtime.java 92.92% <100.00%> (酶)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mpkorstanje mpkorstanje changed the title [Core] Collect exceptions upon emitting TestRunFinished event [Core] Emit exceptions on failure to handle test run finished events Dec 2, 2022
@mpkorstanje mpkorstanje marked this pull request as ready for review December 2, 2022 11:10
The runtime would collect exceptions thrown upon emitting the TestRunFinished
event. The assumption was that these were collected in the test context.
Though this is impossible. The test context is collecting exceptions to include
in the report. So it sits inside the test run started and finished events.
@mpkorstanje mpkorstanje merged commit 51cde87 into main Dec 2, 2022
@mpkorstanje mpkorstanje deleted the core-fix-swallowed-exception branch December 2, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant