Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Mark Allure 5 and 6 plugins as incompatible #2652

Merged
merged 1 commit into from Dec 2, 2022

Conversation

mpkorstanje
Copy link
Contributor

@mpkorstanje mpkorstanje commented Nov 27, 2022

🤔 What's changed?

This bans the use of the incompatible plugins

io.qameta.allure.cucumber5jvm.AllureCucumber5Jvm
io.qameta.allure.cucumber6jvm.AllureCucumber6Jvm

This will prevent users from making the mistake of using the wrong plugin
version with Cucumber. This avoids questions and noise all around.

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@codecov
Copy link

codecov bot commented Nov 27, 2022

Codecov Report

Merging #2652 (4c8f130) into main (5cdd1c5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 4c8f130 differs from pull request most recent head 8134be6. Consider uploading reports for the commit 8134be6 to get more accurate results

@@            Coverage Diff            @@
##               main    #2652   +/-   ##
=========================================
  Coverage     84.77%   84.77%           
  Complexity     2686     2686           
=========================================
  Files           322      322           
  Lines          9530     9532    +2     
  Branches        903      903           
=========================================
+ Hits           8079     8081    +2     
  Misses         1120     1120           
  Partials        331      331           
Impacted Files Coverage Δ
...in/java/io/cucumber/core/options/PluginOption.java 91.86% <100.00%> (+0.19%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mpkorstanje mpkorstanje changed the title [Core] Ban Allure 5 and 6 [Core] Mark Allure 5 and 6 plugins as incompatible Dec 2, 2022
This bans the use of the incompatible plugins

```
io.qameta.allure.cucumber5jvm.AllureCucumber5Jvm
io.qameta.allure.cucumber6jvm.AllureCucumber6Jvm
```

This will prevent users from making the mistake of using the wrong plugin
version with Cucumber. This avoids questions and noise all around.
@mpkorstanje mpkorstanje marked this pull request as ready for review December 2, 2022 10:40
@mpkorstanje mpkorstanje merged commit d9a5afd into main Dec 2, 2022
@mpkorstanje mpkorstanje deleted the core-ban-allure-5-and-6 branch December 2, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant