Run in parallel mode with JUnit #86

aslakhellesoy · 2011-11-10T18:21:23Z

See http://groups.google.com/group/cukes/msg/12ad0e5b2f2a846a

awostenberg · 2011-11-10T19:21:06Z

+1 this. Parallel runner is one of the tips outlined in specification by example to get quick feedback as collections of tests grow. Quick feedback amplifies learning.

cgleissner · 2011-11-10T19:39:50Z

This issue can be replicated via https://github.com/cgleissner/cucumber-jvm/tree/master/examples/java-parallel

Use mvn clean install -Pparallel to enable a parallel build of two tests, using two threads. The README.txt in that example project contains further details.

tpesce · 2011-11-10T20:18:20Z

+1 - I'd love to see this working.

aslakhellesoy · 2012-03-26T08:07:59Z

I have updated your branch @cgleissner : master...java-parallel-example

Seems to be working fine now. So I guess as long as the user is properly partitioning what to run with several @Cucumber.Options(features = {.....}) they will be run in parallel. Please let me know if I'm missing something.

cgleissner · 2012-03-26T14:08:02Z

Hi Aslak,

I tried the parallelism feature and it works now, which is great. Thanks a
lot for your hard work on Cucumber-JVM!

Regards
Christian

On Mon, Mar 26, 2012 at 2:08 AM, Aslak Hellesy <
reply@reply.github.com

wrote:

I have updated your branch @cgleissner :
master...java-parallel-example

Seems to be working fine now. So I guess as long as the user is properly
partitioning what to run with several @Cucumber.Options(features = {.....}) they will be run in parallel. Please let me know if I'm missing
something.

Reply to this email directly or view it on GitHub:
#86 (comment)

Christian Gleissner, Senior Software Engineer
2560 55th St. | Boulder, Colorado 80301

P chris_gleissner (Skype)
www.tendrilinc.com | blog http://www.tendrilinc.com/category/blog/

This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed.
If you have received this email in error please notify the sender.
Please note that any views or opinions presented in this email are solely those of the author and do not necessarily represent those of the company.
Finally, the recipient should check this email and any attachments for the presence of viruses.
The company accepts no liability for any damage caused by any virus transmitted by this email.

aslakhellesoy · 2012-03-26T14:10:01Z

Great - I'll close this then.

cgleissner · 2012-03-26T14:15:19Z

Hi Aslak,

the new feature works great with Surefire 2.10.

However, when I try to upgrade Surefire to 2.12, it fails. That new version
supports parallelism while forking the JVM, which is a very useful feature
to ensure completely de-coupled tests in non thread-safe code.

This occurs with JUnit 4.10 and Cucumber-JVM 1.0.0.RC24 under Apache Maven
3.0.4 and Java 1.6.0_29 on a Mac.

Example along with some logging in the step methods:

-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Concurrency config is parallel='classes', perCoreThreadCount=true,
threadCount=4, useUnlimitedThreads=false
log4j:ERROR Could not find value for key log4j.appender.FILE
log4j:ERROR Could not instantiate appender named "FILE".
08:12:42,152 INFO  [pool-1-thread-1     ] PersonalGrowthSteps :
thePersonExists(0.0) (instance: 0)
08:12:42,152 INFO  [pool-1-thread-2     ] PersonalGrowthSteps :
thePersonExists(0.0) (instance: 1)
08:12:42,153 INFO  [pool-1-thread-1     ] PersonalGrowthSteps :
thePersonGrowsBy(1.0) (instance: 0)
08:12:42,153 INFO  [pool-1-thread-2     ] PersonalGrowthSteps :
thePersonGrowsBy(1.0) (instance: 1)
08:12:42,154 INFO  [pool-1-thread-1     ] PersonalGrowthSteps :
thePersonWillBe(1.0) (instance: 0)
08:12:42,154 INFO  [pool-1-thread-2     ] PersonalGrowthSteps :
thePersonWillBe(1.0) (instance: 1)
08:12:42,155 INFO  [pool-1-thread-1     ] PersonalGrowthSteps :
thePersonExists(5.0) (instance: 2)
08:12:42,155 INFO  [pool-1-thread-2     ] PersonalGrowthSteps :
thePersonExists(5.0) (instance: 3)
08:12:42,156 INFO  [pool-1-thread-1     ] PersonalGrowthSteps :
thePersonGrowsBy(1.0) (instance: 2)
08:12:42,156 INFO  [pool-1-thread-2     ] PersonalGrowthSteps :
thePersonGrowsBy(1.0) (instance: 3)
08:12:42,157 INFO  [pool-1-thread-1     ] PersonalGrowthSteps :
thePersonWillBe(6.0) (instance: 2)
08:12:42,157 INFO  [pool-1-thread-2     ] PersonalGrowthSteps :
thePersonWillBe(6.0) (instance: 3)


org.apache.maven.surefire.util.SurefireReflectionException:
java.lang.reflect.InvocationTargetException; nested exception is
java.lang.reflect.InvocationTargetException: null
java.lang.reflect.InvocationTargetException
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at
org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189)
at
org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165)
at
org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85)
at
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:103)
at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:74)
Caused by: org.apache.maven.surefire.testset.TestSetFailedException:
java.lang.NullPointerException; nested exception is
java.lang.NullPointerException: null
at
org.apache.maven.surefire.common.junit4.JUnit4RunListener.rethrowAnyTestMechanismFailures(JUnit4RunListener.java:166)
at
org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUnitCoreWrapper.java:63)
at
org.apache.maven.surefire.junitcore.JUnitCoreProvider.invoke(JUnitCoreProvider.java:139)
... 9 more
Caused by: java.lang.NullPointerException
at
org.apache.maven.surefire.junitcore.ConcurrentReporterManager.testStarting(ConcurrentReporterManager.java:106)
at
org.apache.maven.surefire.common.junit4.JUnit4RunListener.testStarted(JUnit4RunListener.java:87)
at
org.junit.runner.notification.RunNotifier$3.notifyListener(RunNotifier.java:87)
at
org.junit.runner.notification.RunNotifier$SafeNotifier.run(RunNotifier.java:41)
at
org.junit.runner.notification.RunNotifier.fireTestStarted(RunNotifier.java:84)
at
org.junit.internal.runners.model.EachTestNotifier.fireTestStarted(EachTestNotifier.java:45)
at cucumber.junit.JUnitReporter.startExecutionUnit(JUnitReporter.java:43)
at cucumber.junit.ExecutionUnitRunner.run(ExecutionUnitRunner.java:46)
at cucumber.junit.FeatureRunner.runChild(FeatureRunner.java:50)
at cucumber.junit.FeatureRunner.runChild(FeatureRunner.java:17)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:229)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:50)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:222)
at org.junit.runners.ParentRunner.run(ParentRunner.java:300)
at cucumber.junit.FeatureRunner.run(FeatureRunner.java:57)
at cucumber.junit.Cucumber.runChild(Cucumber.java:76)
at cucumber.junit.Cucumber.runChild(Cucumber.java:36)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:229)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:50)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:222)
at org.junit.runners.ParentRunner.run(ParentRunner.java:300)
at cucumber.junit.Cucumber.run(Cucumber.java:81)
at
org.apache.maven.surefire.junitcore.ClassDemarcatingRunner.run(ClassDemarcatingRunner.java:58)
at org.junit.runners.Suite.runChild(Suite.java:128)
at org.junit.runners.Suite.runChild(Suite.java:24)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
at java.util.concurrent.FutureTask.run(FutureTask.java:138)
at
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
at java.lang.Thread.run(Thread.java:680)

Results :

Tests run: 0, Failures: 0, Errors: 0, Skipped: 0

[INFO]
------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 2.831s
[INFO] Finished at: Mon Mar 26 08:12:42 MDT 2012
[INFO] Final Memory: 10M/554M
[INFO]
------------------------------------------------------------------------

aslakhellesoy · 2012-03-26T14:21:37Z

Please create a new ticket for this, and please use GFM to format logs

…mber/cucumber-jvm#86

mrunalgosar · 2015-11-26T19:36:30Z

Hi aslakhellesoy.. i have found a neater way of implementing cucumber jvm parallel runs. i have small POC ready.. Let me know how can i send it for review?

aslakhellesoy · 2015-11-26T20:21:53Z

Just send a pull request or put it in a new repo on github.

mrunalgosar · 2015-11-27T19:24:57Z

Hi aslakhellesoy.. I've forked the project, added the POC related changes to the JUnit project and commited it to forked source here: https://github.com/mrunalgosar/cucumber-jvm.git. Look at package: cucumber.api.junit.parallel. Let me know your views if this approach is doable further, then i can work on the same and get this feature implemented properly.
Regards Mrunal

mrunalgosar · 2015-11-28T13:20:06Z

Hi aslakhellesoy.. I've forked the project, added the POC related changes
to the JUnit project and commited it to forked source here:
https://github.com/mrunalgosar/cucumber-jvm.git. Look at package:
cucumber.api.junit.parallel. Let me know your views on it. If this approach
is doable further, then i can work on the same and get this feature
implemented properly.
Regards Mrunal

On Fri, Nov 27, 2015 at 1:52 AM, Aslak Hellesøy notifications@github.com
wrote:

Just send a pull request or put it in a new repo on github.

—
Reply to this email directly or view it on GitHub
#86 (comment)
.

aslakhellesoy · 2015-11-28T16:21:19Z

Many people use Cucumber without using the JUnit runner. Core functionality (such as parallel execution) should not depend on JUnit.

Another thing we need to handle well is results - if there are many threads running scenarios, the results should still be collected and reported in the same way as if there were only one thread.

We'll implement this our own way, based on Gherkin3's pickles.

mrunalgosar · 2015-11-29T19:02:07Z

Ok..sounds Fair enough.. i'll probably keep it in some kind of util and
share it if anyone is interested till the time gherkin3 comes alive.

Regards
Mrunal

On Sat, Nov 28, 2015 at 9:51 PM, Aslak Hellesøy notifications@github.com
wrote:

Many people use Cucumber without using the JUnit runner. Core
functionality (such as parallel execution) should not depend on JUnit.

Another thing we need to handle well is results - if there are many
threads running scenarios, the results should still be collected and
reported in the same way as if there were only one thread.

We'll implement this our own way, based on Gherkin3's pickles.

—
Reply to this email directly or view it on GitHub
#86 (comment)
.

lock · 2018-10-25T05:26:27Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

aslakhellesoy closed this as completed Mar 26, 2012

mattharr mentioned this issue Jan 29, 2013

Parallel running with surefire 2.12 #333

Closed

chiranjith pushed a commit to chiranjith/cucumber-jvm that referenced this issue Mar 15, 2015

Example to demonstrate that parallel Junit tests are broken, see cucu…

cf6347f

…mber/cucumber-jvm#86

lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run in parallel mode with JUnit #86

Run in parallel mode with JUnit #86

aslakhellesoy commented Nov 10, 2011

awostenberg commented Nov 10, 2011

cgleissner commented Nov 10, 2011

tpesce commented Nov 10, 2011

aslakhellesoy commented Mar 26, 2012

cgleissner commented Mar 26, 2012

aslakhellesoy commented Mar 26, 2012

cgleissner commented Mar 26, 2012

aslakhellesoy commented Mar 26, 2012

mrunalgosar commented Nov 26, 2015

aslakhellesoy commented Nov 26, 2015

mrunalgosar commented Nov 27, 2015

mrunalgosar commented Nov 28, 2015

aslakhellesoy commented Nov 28, 2015

mrunalgosar commented Nov 29, 2015

lock bot commented Oct 25, 2018

Run in parallel mode with JUnit #86

Run in parallel mode with JUnit #86

Comments

aslakhellesoy commented Nov 10, 2011

awostenberg commented Nov 10, 2011

cgleissner commented Nov 10, 2011

tpesce commented Nov 10, 2011

aslakhellesoy commented Mar 26, 2012

cgleissner commented Mar 26, 2012

aslakhellesoy commented Mar 26, 2012

cgleissner commented Mar 26, 2012

aslakhellesoy commented Mar 26, 2012

mrunalgosar commented Nov 26, 2015

aslakhellesoy commented Nov 26, 2015

mrunalgosar commented Nov 27, 2015

mrunalgosar commented Nov 28, 2015

aslakhellesoy commented Nov 28, 2015

mrunalgosar commented Nov 29, 2015

lock bot commented Oct 25, 2018