Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added extraGlue option to @CucumberOptions #1439

Merged
merged 1 commit into from Aug 25, 2018
Merged

Added extraGlue option to @CucumberOptions #1439

merged 1 commit into from Aug 25, 2018

Conversation

ekalin
Copy link
Contributor

@ekalin ekalin commented Aug 23, 2018

Summary

Added extraGlue option to @CucumberOptions

Details

This option works similarly to glue, specifing packages in which to search for steps and hooks, but the default search path (the current package) is included in the list of glue packages, whereas glue includes only the explicitly listed packages.

Motivation and Context

Closes #1438.

How Has This Been Tested?

I've added tests to RuntimeOptionsFactoryTest.java.

mvn clean install is successful.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

The only documentation I've found is JavaDocs in CucumberOptions.java; the new option is documented there.

This option works similarly to glue, specifing packages in which to
search for steps and hooks, but the default search path (the
current package) is included in the list of glue packages, whereas
glue includes only the explicitly listed packages.

Closes #1438.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 85.451% when pulling 1e9f1c2 on ekalin:extra-glue into 1c33961 on cucumber:master.

@mpkorstanje mpkorstanje merged commit 532be3e into cucumber:master Aug 25, 2018
@aslakhellesoy
Copy link
Contributor

Hi @ekalin,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

@mpkorstanje
Copy link
Contributor

Thanks!

@lock
Copy link

lock bot commented Aug 26, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New option extraGlue in @CucumberOptions - adds packages to search, keeping default package
4 participants